commit 1d012c39d3d7f63286449a2ef4ccf2196b0d3f6e Author: Katrin Fischer Date: Wed Nov 20 18:11:23 2024 +0000 Bug 38436: DBRev 24.06.00.064 Signed-off-by: Katrin Fischer commit 846624e754eb4557d80349a6d45c6f568c7faaf6 Author: Jonathan Druart Date: Tue Nov 19 17:29:56 2024 +0100 Bug 38485: Take user's previous change into consideration for holdings tables col vis A lot happened, hard to summarize everything. Basically at this point, we have (among other things): * fixed bug 38118 (but reintroduced it with bug 36640) * fixed bug 38436 (the original report was that the is_hidden setting was no longer taken into effect on the holdings tables) Here we are trying to deal with making user's previous changes persistent across the pagination and col vis changes. Test plan: Confirm that hiding checkouts in settings hide the columns Confirm that showing checkouts then change page (*pagination*, so you need more than 20 items) and confirm that the columns are still the same Add a callnumber for an item from page 2 and confirm that the column is hidden on page 1 and shown on page 2 Hide callnumber from the settings and confirm that the column is hidden on pages 1 and 2 Show callnumber from the holdings page and confirm that the column is displayed on page 2, go page 1: hidden, go back page 2: displayed. And certainly way more other things to test, just confirm that the behaviours with this patch are consistent with what a end user would expect. Note for QA/self: this is not very nice as column-visibility.dt event can change in datatables.js and not impact this one. Also the following nice sounds good and should be added to datatables.js + if (recalc === false) return; Signed-off-by: Katrin Fischer commit 6a6fd6ab2bc1010b393b16b9a8502815812d9328 Author: Jonathan Druart Date: Tue Nov 19 15:15:49 2024 +0100 Bug 38482: Deactivate 'save state' for holdings tables This is too complicated (at least for 24.11.00) to have everything works in all situations. This table has this specific "hide when empty" behaviour which complicated how we deal with/restore the state Signed-off-by: Katrin Fischer commit 80c0fd02bf73fe54211af02d72a6c0fa2609c175 Author: Jonathan Druart Date: Tue Nov 19 10:25:06 2024 +0100 Bug 38482: Remove save state for the holdings tables On the holdings table of the bibliographic record detail page, we have a special behaviour: we hide columns if there is no data to display. Indeed we have a lot of column and we want to limit the number of columns displayed. This behaviour conflicts with "Save state": when the columns are hidden the state is modified. If you leave the page and come back, the column will stay hidden, even if the global settings does not have it as hidden and even if the user didn't explicitly hide it. We want to implement something correctly to prevent a conflict with those 2 behaviours, but 24.11.00 is coming and we need a quick fix: here we are going to remove save state for these 2 tables. Test plan: Apply this patch, restart_all Go to the tables settings admin, jump to holdings_table Notice that "Save configuration state on page change" is turned off by default Go to catalogue/detail.plbiblionumber=13 (item does not have call number) => "Call number" column is not displayed Edit the item, set a call number Go to catalogue/detail.plbiblionumber=13 (item has call number) => "Call number" column is displayed Go to the tables settings admin, jump to holdings_table Turn on "Save configuration state on page change" Go to catalogue/detail.plbiblionumber=1 (item does not have call number) => "Call number" column is not displayed Edit the item, set a call number Go to catalogue/detail.plbiblionumber=13 (item does not have call number) => "Call number" column is still not displayed This can be considered a bug, that why we are disabling the feature for this table. Signed-off-by: Michaela Sieber Signed-off-by: PhilipOrr Signed-off-by: Katrin Fischer commit 7ed8295ba765d235878b8a245c230f931af2506c Author: Jonathan Druart Date: Wed Nov 20 10:32:13 2024 +0100 Bug 38436: Fix OPAC tables This patch sync columns_settings.inc for the OPAC-side It however removes 'api' from datatables.js as it is never used. 'api' was renamed 'kohaTable' on bug 29408 but OPAC was forgotten. Better to not have to deal with this unused code for now, we will reintroduce it if needed later. Signed-off-by: Katrin Fischer commit c1daf6b2c248f1baebe5cc81b752bddbf49d59d4 Author: Jonathan Druart Date: Mon Nov 18 14:48:42 2024 +0100 Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit f346a2e0deb5c2abc05cf993a5be047cfde104b1 Author: Jonathan Druart Date: Mon Nov 18 14:47:57 2024 +0100 Bug 38436: (follow-up) Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 57f01d5b6efe797e3eb9a9784828994931e5e697 Author: Jonathan Druart Date: Mon Nov 18 14:47:13 2024 +0100 Bug 38436: (follow-up) Adjust columns_settings.inc for KohaTable Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 969074e0d3ed028a951d4f3d59a15a3a990d57d8 Author: Jonathan Druart Date: Sat Nov 16 08:05:05 2024 +0100 Bug 38436: Do not deal with 'Columns' button if no table settings If the table does not have table settings we should not deal with the column visibility and not display the 'Columns' button. Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 8b975299c7f1a3f25d9c327fef6594a62270fd5a Author: Jonathan Druart Date: Sat Nov 16 08:03:21 2024 +0100 Bug 38436: Adjust Vue Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit e9a4154278d900d45e5d297045ba76b653979d7e Author: Jonathan Druart Date: Fri Nov 15 22:07:55 2024 +0100 Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Typically the patrons search. Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit ed779002e373edce1a818d97525cf9f4ff168780 Author: Jonathan Druart Date: Fri Nov 15 16:12:11 2024 +0100 Bug 38436: Do not hide all if none to hide Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 5829cb6b4ffdfce5daabefd5902f682d9ed36d6b Author: Jonathan Druart Date: Fri Nov 15 16:06:23 2024 +0100 Bug 38436: Restore hide columns when empty If a column has no data on the items table we should hide the column. Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit a29dac838591616d6597d13196629480c3ad643e Author: Jonathan Druart Date: Fri Nov 15 16:04:23 2024 +0100 Bug 38436: Adjust columns_settings.inc for KohaTable Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 369ca5b0fd45864dc5488d45e0d060dc2b8f9378 Author: Jonathan Druart Date: Fri Nov 15 15:28:41 2024 +0100 Bug 38436: Fix column visibility when bKohaColumnsUseNames is used When the columns displayed in the table can vary (depending on sysprefs) we use bKohaColumnsUseNames. This allows us to use the name of the columns instead of there order number. The code was totally wrong, and didn't retrieve the correct number. A good example to confirm that is to add: console.log("%s is at %s".format(this.columnname, used_id)); at the end of the `if ( use_names ) {` block of _dt_visibility. If at least one column is hidden by default and cannot be toggled (and so won't appear in the list of the columns of the "Column visibility" button), there will be a shift. This line was definitelly wrong: var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); We cannot rely on the order of the visible columns, we need to retrieve the list of the columns using DT's api. Now the columns are retrieved using their class names, and from DT's api. The code is way nicer and more inline with how we are supposed to play with DT. Look at those 2 lines to pass the list of columns to the colvis button: let included_columns = table_settings.columns.filter(c => !c.cannot_be_toggled); columns: included_columns.map(c => '.' + c.columnname).join(',') Test plan: Play intensively with the items table (detail.pl), but also with the other tables not using bKohaColumnsUseNames (eg. patrons search) You need to set column as hidden by default and/or cannot be toggled. You need to play with the "Columns" button. Note that you need to remove the localStorage keys starting with 'DataTables_' to retrieve the visibility settings from what is defined in the admin area. Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 4e12775e4fd624d221ed78d0675f0b4f42171bc2 Author: Jonathan Druart Date: Fri Nov 15 15:28:08 2024 +0100 Bug 38436: Rename columns_settings.columnname in DB Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 42df19b3e16adc9f499f758a7f4a468140349ae2 Author: Jonathan Druart Date: Fri Nov 15 15:18:38 2024 +0100 Bug 38436: Adjust column names for the holdings tables Removing the prefix holdings_ and otherholdings_ Could have been done at the code level but does not seem necessary to have different column names Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 558d4335f89192354969fde9d1464b8a9641a4d4 Author: Jonathan Druart Date: Fri Nov 15 15:04:40 2024 +0100 Bug 38436: Store loaded_from_state in data instead of DT's settings This has been introduced by bug 33484 as we needed to know if the state was loaded (from URL or localStorage). If the state is loaded then we need to: 1. not redirect if only one patron to display (to prevent a blocking situation) 2. display the table (ie. not defer loading) Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit f29ed160aae9b6a0697ff3528b1df90989b5220c Author: Jonathan Druart Date: Fri Nov 15 14:55:20 2024 +0100 Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 0d24de094aa1be5b5b3f1e6fe885f0558089b0f3 Author: Jonathan Druart Date: Fri Nov 15 14:46:28 2024 +0100 Bug 38436: Do not try to build the table if tab is not there If we don't have the "other holdings" tab, no need to try to build the table. Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 5dad538b4024b51beb6b1036ce9420c71a979c35 Author: Nick Clemens Date: Tue Nov 19 18:28:30 2024 +0000 Bug 28294: (follow-up) Adjust call to request transfer The call expects a library object, not a branchcode, likely rebasing issue To test: 1 - Place a hold for an item at a different library than current library 2 - Check item in and confirm transfer 3 - Check item in again 4 - Kaboom! 5 - Apply patch/restart_all 6 - Check item in again 7 - Ok! Signed-off-by: Katrin Fischer commit 459be649761eec12998a7ba2d5fb1ba73e426cf3 Author: Pedro Amorim Date: Wed Nov 20 10:40:54 2024 +0000 Bug 38492: Update occurrences of _() to __() Test plan, ktd: 1) Generate translation files $ gulp po:update --lang de-DE 2) Verify that strings using _() do not exist on the pot file: $ cat -n misc/translator/Koha-messages-js.pot | grep "Copied!" $ cat -n misc/translator/Koha-messages-js.pot | grep "Form not submitted because of the following problem" $ cat -n misc/translator/Koha-messages-js.pot | grep "No matches found" 3) Apply patch. Repeat test plan. Signed-off-by: Katrin Fischer commit d2a6c4673b66984583699c9ea0fec0eda5460766 Author: Katrin Fischer Date: Tue Nov 19 16:08:10 2024 +0000 38424: Update yarn.lock Signed-off-by: Katrin Fischer commit 884197cf830d211002ce5716d01e786c054bd4c1 Author: Tomás Cohen Arazi Date: Tue Nov 12 13:44:55 2024 +0000 Bug 38424: Upgrade redoclyly/cli version to latest stable This patch updates the used version of redocly/cli to the latest stable. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle => FAIL: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json ╔════════════════════════════════════════════════════════╗ ║ ║ ║ A new version of Redocly CLI (1.25.11) is available. ║ ║ Update now: `npm i -g @redocly/cli@latest`. ║ ║ Changelog: https://redocly.com/docs/cli/changelog/ ║ ║ ║ ╚════════════════════════════════════════════════════════╝ bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 207ms. Done in 1.34s. ``` 3. Apply this patch 4. Run: k$ sudo yarn install --modules-folder /kohadevbox/node_modules 5. Repeat 2: => SUCCESS: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 200ms. Done in 1.29s. ``` 6. Restart plack and check the API loads without issues: k$ koha-plack --restart kohadev; tail -f /var/log/koha/kohadev/*.log 7. Run the tests: k$ prove -r t/db_dependent/api/ => SUCCESS: No failures 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 4bfb4da587ae320766b7428eb2bbcc8f2503876e Author: Matthias Meusburger Date: Tue Nov 19 13:54:41 2024 +0000 Bug 35659: (QA follow-up) Fix DateTime and cronlogaction messages Signed-off-by: Katrin Fischer commit 57f317ff10765a72d88a3be9075f6418c61b7986 Author: Jonathan Druart Date: Tue Nov 19 11:39:24 2024 +0100 Bug 36640: (follow-up) Fix itemsearch We replaced 'columnFilter', and it's no longer there. Signed-off-by: Katrin Fischer commit 14f049908682b38d6112c37dcc449744edc0fc79 Author: Lucas Gass Date: Thu Oct 31 14:53:49 2024 +0000 Bug 38315: Add expired class to expired patrons in patron search results To test: 0. APPLY PATCH 1. Have some expired patrons 2. Do a search that will return some expired patrons and some not expired. 3. Look at the 'Expires on' column. 4. The expired patrons should have an expired class set and the date should be red/italic. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit abfba936fb4ffcab5d1234c3fc577ac493865c5e Author: Janusz Kaczmarek Date: Wed Oct 23 13:27:52 2024 +0000 Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds With a over-sufficient number of items, when more than one patron has placed hold, and the holds have been partially filled (checked-in = waiting for pick up), the number of items to pull in the Holds to pull table shows the total number of holds, including those waiting. This erroneously suggests to the librarian to pull an excessive number of items from the shelves. Test plan: ========== 1. For a bibliographic record with more than two items (in ktd, e.g. "Lanark a life in four books"), place hold for two patrons. 2. On the Holds to pull page control that there are two items to pull. 3. As a librarian from the library of one of the patrons, Check-in one item. 4. Note that in Holds to pull table you still see two items to pull, which is misleading. 5. Apply the patch; restart_all. 6. Now you should see only one item to be pulled. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 1c6dfb5f3558e297626e2f4a4ba361790044d550 Author: David Nind Date: Sun Nov 10 19:17:02 2024 +0000 Bug 38344: Fix typo - space before exclamation mark in "Thank you !" In English, there should not be a space before an exclamation mark in a sentence. For example, "Thank you !" is not correct. Test plan: 1. Search the codebase for "Thank you !": grep -rn "Thank you !" * 2. Result - one occurance: C4/SIP/ILS.pm:317: return (1, 'Thank you !', ''); 3. Apply the patch. 4. Repeat step 1. 5. There should now be no occurances. Signed-off-by: David Nind Signed-off-by: Phil Ringnalda Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer commit 9a72d3c7576d2c884ea93ae7f065d6836358c3d9 Author: George Veranis Date: Thu Nov 7 14:39:16 2024 +0100 Bug 28075: (follow-up) adding all choices and values of 135a Extend patch of 135a to cover all choices with all possible values as described by IFLA for 135a. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 3fa03e2e660de9c0ab12e8281671963f089c3ef9 Author: Didier Gautheron Date: Thu Nov 7 14:32:35 2024 +0100 Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit ddddaf2e3dc052660fd0e220e594407bde8131df Author: Phil Ringnalda Date: Fri Nov 15 14:13:11 2024 -0800 Bug 38463: Unnecessary CSRF token in OPAC authority search Bug 37069 correctly changed OPAC authority searches from a POST to a GET, but forgot to remove the CSRF token that is only needed for a POST, so now it clutters up the URL by making the first 107 characters of the query string meaningless. Test plan: 1. Without the patch, in the OPAC, go to Authority search 2. Change the dropdowns to non-default values so you have meaningful search conditions, and search for something that will return results, like Topical Term/starts with/a/in any heading/Heading descendant 3. Copy the URL of your search results, paste it in an email compose window, look at what you just pasted and wonder whether that big opaque string is actually safe to send to a coworker. Go to lunch. Come back and wonder what you searched for, and look at the URL in the browser to try to tell 4. Apply patch, click the browser back button, reload the page, search again 5. Copy and paste the URL, notice it looks fine to send, just a search. Look at the URL in the browser address bar, notice that within the limits of your window size, you can see what you searched for Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 72d332b0ce78949fb1a1db390a4af5dfd0e33150 Author: Owen Leonard Date: Fri Sep 20 12:01:11 2024 +0000 Bug 37946: (follow-up) Update menu style to hide We shouldn't use hide() to hide the Bootstrap menu. The correct move here is to empty the "style" attribute. Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 38ade44def127e4b8a1f81877562e5328d7bd335 Author: Owen Leonard Date: Wed Sep 18 17:49:21 2024 +0000 Bug 37946: Double menu when clicking the caret in Z39.50 search This patch makes some adjustments to the JS for the Z39.50 search results page to correct the behavior of dropdown menus. If the split button's menu trigger is clicked a cloned version of the menu shouldn't appear along with the default one. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> New from Z39.50. - Perform a search which will return multiple results. - Click any table cell in the results except the last one. - You should get a popup menu with "MARC preview," "Card preview," and "Import." - Each menu item should work correctly. - Test the button in the last column to confirm that both the "primary" button works correctly and that the popup menu works correctly. - Test the process of adding a new authority from Z39.50 to confirm that the authority search results table works the same as the bibliographic one. Signed-off-by: David Nind Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 7cf80c0b6de07d3da8d39d10ae443a4b15bcaffd Author: Matt Blenkinsop Date: Mon Nov 18 11:34:17 2024 +0000 Bug 38326: (QA follow-up) Tidy Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 9d3d165207315c503a3905c6589b840526ed5701 Author: Lucas Gass Date: Fri Nov 1 16:31:11 2024 +0000 Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work. Signed-off-by: Sam Sowanick Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 5bb6f8c1cbab21a12076c4b0f87436d1f8540478 Author: Katrin Fischer Date: Tue Nov 19 08:11:04 2024 +0000 Revert "Bug 38299: [DO NOT PUSH] Test dbrev" This reverts commit 0be29ed976a682bc85f669860850ac331fcca633. Signed-off-by: Katrin Fischer commit d7ae20f0cb4bc0850896617aae59ec22fedcc71d Author: Owen Leonard Date: Mon Jul 1 12:28:56 2024 +0000 Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorsSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorisSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorsSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit a873200517358d0fbc31c6f4be20ebe39464218f Author: Owen Leonard Date: Mon Nov 4 14:44:46 2024 +0000 Bug 38346: Make sidebar checkboxes consistent This patch makes some changes to markup and CSS in order to make checkboxes in sidebars more consistent with each other and better styled. To test apply the patch and rebuild the staff interface CSS. Check the sidebar forms on these pages and verify that the checkbox inputs look correct. The label should be on the same line as the checkbox. - Serials -> Search serials -> Results: The "Has routing list" line. - Administration -> Funds: The "Show my funds only" checkbox. - Circulation -> Overdues: "Show any items currently checked out." - Suggestions: "Include archived." Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6807b62104b62b5eaa7326a2dfb7ba2def0d3ab2 Author: Emily Lamancusa Date: Tue Nov 12 15:46:08 2024 -0500 Bug 37866: (QA follow-up) Fix another missed case Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 974c9bd76efadaf3130a3cb678ae5cdf2b24da2d Author: Emmi Takkinen Date: Wed Sep 11 14:05:33 2024 +0300 Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit c654f4cb40202b6ec539a756a9ee3408448e49ae Author: Jonathan Druart Date: Wed Nov 13 12:14:50 2024 +0100 Bug 38299: (follow-up) (discussion) Move failure into same level Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 5a5a0dbbce476b4119d6f18f0eb824e479e4227b Author: Martin Renvoize Date: Tue Nov 12 15:23:30 2024 +0000 Bug 38299: (discussion) Move failure into same level This patch adds the failures in at the same level as the rest of the revision output (i.e. indented under the specific database revision) and uses the standard failure coloring instead of the local update_error class. This is a proposal and may need more work to clarify and perhaps remove the duplicated/collected errors at the bottom of the update. Now that we hard stop if an update fails, I'm not sure collecting errors at the bottom makes as much sense as it once did? Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit c5d899c584560793e64bce507a2cad7e838afa0d Author: Emily Lamancusa Date: Thu Nov 7 11:17:12 2024 -0500 Bug 38299: Update tests To test: prove -v t/Koha/Installer/Output.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit c79d533a04de86bd6a739b44b47af4cce4bdc8e7 Author: Emily Lamancusa Date: Thu Nov 7 10:28:55 2024 -0500 Bug 38299: Use say_failure when printing update errors to the console Bug 35681 added subroutines to print colored output from database updates. Incorporate the subroutine say_failure into the error handling in the upstream code, so that errors caught upstream can take advantage of this new subroutine and display in red. To test: 1. Apply patch for test dbrev 2. From the kshell, run updatedatabase --> The messages for success, info, warning, and failure that were explicitly printed in the dbrev are colored, but the database error is not colored. 3. Apply other patches 4. Run updatedatabase again --> All messages including the database error are now colored Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit bae04ca3fd577267987554fd2a5f81b2927125fe Author: Emily Lamancusa Date: Thu Nov 7 10:21:19 2024 -0500 Bug 38299: Make filehandler optional for colored outputs Allow say_success, say_failure, etc, to omit the filehandler parameter so that they can be used without explicitly opening a filehandler if you are just printing to STDOUT and don't already have one. If a filehandler is passed, the existing behavior is unchanged. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 0be29ed976a682bc85f669860850ac331fcca633 Author: Emily Lamancusa Date: Thu Nov 7 10:20:01 2024 -0500 Bug 38299: [DO NOT PUSH] Test dbrev Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 70f001d8b86c0a52324315fc97e524763f44219d Author: Owen Leonard Date: Wed Nov 6 16:32:33 2024 +0000 Bug 38380: Fix other instances of obsolete col-*-offset classes from templates This patch corrects a few remaining instances of obsolete col-*-offset classes from a few different templates. To test, apply the patch and make sure you have the system preferences AllowCheckoutNotes and ArticleRequests. - Go to Circulation -> Article requests. If necessary, create an article request. - From the list of requests, click Actions -> Cancel request. The "Confirm deletion" modal form should be well-formatted. - From the list of requests, under the "New" tab, click a record title to view the details for that article request. - In the list of patron requests, click the "X" to delete the request. The "Confirm deletion" modal form should be well-formatted. - Log into the OPAC as a user with checkouts. On your summary page, under the "Checked out" tab, click the "Add note" button and save a new note. - Go to Circulation -> Checkout notes. The layout should look correct. Toggle the CircSidebar system preference and reload the checkout notes page. It should still look correct. - The last change, to the patron clubs template page, only modifies a comment. Signed-off-by: David Nind Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer commit 77c003ed544d653345acf4debe968110ea94a1fd Author: Phil Ringnalda Date: Tue Nov 12 21:31:02 2024 -0800 Bug 29818: Cannot save subscription frequency without display order The schema says that subscription_frequencies.displayorder can be null, and everything else deals with it being null just fine, but if you try to save a new frequency without specifying display order with strict_sql_modes set, you get an error. Test plan: 1. Without the patch, Serials - Manage frequencies - New frequency 2. Description is mandatory, so fill it in, then click Save 3. Boom! Apply patch, restart_all 4. Repeat steps 1-2, and verify that no error is thrown and the new frequency shows up (at the top of the list since nothing comes before something) 5. New frequency, fill in Description, try typing something other than a number in Display order and saving. You should be told to follow the directions that only numeric characters are allowed Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer commit d794891005e4a457371bd9ecaaf845e70fe85255 Author: Nick Clemens Date: Thu Jul 11 12:03:40 2024 +0000 Bug 37326: decode barcode file in inventory tool This patch ensures that barcodes uploaded as a file into batchMod are run through any transformations to match the behaviour of barcodes entered in a list To test: 1 - Edit BarcodeSeparators system preference to remove \s 2 - Install barcode transformer plugin: https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/tag/v1.2.0 3 - Configure the plguin: item: - match: "^[A-Z]* \| " search: "^[A-Z]* \| " replace: "" - match: " \| .*$" search: " \| .*$" replace: "" 4 - Go to Cataloging->Batch item modification 5 - Enter a list of barcodes into the 'Scan one by one' box like: ERR | 12345 | ERR FOO | 23456 | FOO BAR | 34567 | BAR 6 - Click 'Continue' 7 - Note the barcodes not found are: 12345 23456 34567 8 - Save the barcodes with extra text into a file 9 - Perform batch mod, supplying the barcodes via the file 10 - Note the barcodes not found are the original strings 11 - Apply patch, restart all 12 - Perform batch modification using file again 13 - Note the not found barcodes are the transformed version 14 - Sign off! Signed-off-by: Brendan Lawlor Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer