commit 00a36e940b8f712a419cabc457db365b9602ff70 Author: Thibaud Guillot Date: Tue Dec 3 14:04:51 2024 +0100 Bug 38493: Add possibility to add mutliple bookings at once Note: For now it's implemented only on the OPAC side If the biblio_id parameter is not present in the url, the modal window will be replaced by another form. Items can be found by barcode, and once added, validated by clicking on the button. Pickup locations will automatically appear according to the item's biblios. Test plan: 1) Apply this patch and restart_all 2) Active booking for one item or itemtype 3) Go on the OPAC url 'cgi-bin/koha/opac-bookings.pl' 4) You can add some items with their barcodes 5) Dynamically delete items if you want 6) And when you're ready, click on 'Validate items' it will check if you can perform a booking for each items with the same pickup library and on the same period Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) commit a3d2c58cfd99f8c28dcc9f2a9c89dd859b855218 Author: Paul Derscheid Date: Fri Sep 20 19:08:26 2024 +0000 Bug 33738: Add bookings feature on the OPAC side Inspired by the work of Paul and Martin, I'm submitting this proposal for the bookings functionality on the OPAC side. Bookings are perform as on the staff side with the api, adding, cancelling and modifying the pickup library works (normally :) ). Test plan: 1) Apply this patch and restart_all 2) Having a bookable item 3) Go to the OPAC side and click on “Place booking” in the menu. 4) Add a booking; if there is an error, it will appear in the modal (preparation of errors linked to circulation rules). 5) Cancel or Modify pickup library Thanks for testing commit f82919adb317de5b989049b2b29af58562f8238e Author: Paul Derscheid Date: Thu Jan 16 17:35:31 2025 +0100 Bug 38167: (QA follow-up) Remove old, add new eslint config to Makefile.PL To test: 1) Run t/Makefile.t, observe failure 2) Apply patch 3) Run t/Makefile.t, observe success Signed-off-by: Katrin Fischer commit aff29616abc3a791c3b3ccf656313c77e21b19db Author: Jonathan Druart Date: Thu Jan 16 16:25:20 2025 +0100 Bug 38727: Add missing closing div Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 7cb370904b4c6ee0abf13db85b6893b6eeca6793 Author: Tomás Cohen Arazi Date: Tue Dec 17 09:50:24 2024 -0300 Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 94ef3bfb47bdd0d2bf5feded17826f0fae5b0cb9 Author: Owen Leonard Date: Thu Jul 20 14:58:07 2023 +0000 Bug 32890: Add DataTables to curbside pickups This patch modifies the curbside pickups page in the staff interface so that each table is a DataTable with configurable columns. The patch also replaces the patron name output with patron-title.inc for consistency and to display names 'surname, firstname' for correct column sorting. To test, apply the patch and restart services. - Enable the CurbsidePickup system preference if necessary. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Go to Circulation -> Curbside pickups. - Test DataTable functionality under each tab: sorting, paging, filtering, column visibility, and export. - Go to Administration -> Table settings -> Circulation -> Curbside pickup - Confirm that changes made to the configuration of each of the 4 curbside pickup tables is correctly applied on the curbside pickups page. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit c42d73ee265780402a697db200019514391f6dea Author: Katrin Fischer Date: Thu Jan 16 16:20:34 2025 +0000 Bug 35152: DBRev 24.12.00.005 Signed-off-by: Katrin Fischer commit 9740f6fa5fce2392beacaa01806fca5edd2f6581 Author: Jonathan Druart Date: Thu Jan 16 12:55:40 2025 +0100 Bug 35152: Display 'syspref removed' success only if removed Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 41a2d2edd2714b13326fccc0e327e26531ede769 Author: Owen Leonard Date: Mon Jan 13 17:10:43 2025 +0000 Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 0e2c3f1d382396e999e6a7c1e08bf129abc1c309 Author: Lucas Gass Date: Mon Dec 30 20:51:01 2024 +0000 Bug 38681: Add flatpickr to datelastborrowed field in itemsearch To test: 1. APPLY PATCH 2. Have some checkouts with various issue dates. 3. Go to item search and look for the 'Last checkout date:' 4. Try some different searches and confirm that they work as expected. 5. Change the DateFormat system preference and make sure the search still works with all the DateFormat optoins. Signed-off-by: William Lavoie Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 13fc87687669f2373130839517458c23379efa86 Author: Lucas Gass Date: Tue Dec 17 16:59:44 2024 +0000 Bug 38732: Add copy number column to manage bundles table To test: 1. APPLY PATCH and restart_all 2. Go to an item record and click 'Manage bundle' 3. Make sure the item you are adding has a copy number. 4. Look at the bundle_table and notice the copy number displaying. 5. Make sure you can hide the column ( Gear icon: Columns ) and via Table settings. Signed-off-by: Hebah Amin-Headley Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 1ae30dedf6c484f1f0896058c3272868ff50efc9 Author: Lucas Gass Date: Fri Dec 13 20:20:04 2024 +0000 Bug 38705: Add serial.publisheddatetext column to OPAC subscriptionst 1. Have or create an item with a serial subscription on it. 2. When receiving make sure you add some publisheddatetext ( Publication date text ) 3. Have a look at the record in the OPAC. 4. In the subscrptions tab there is no 'Publication date text' column. 5. APPLY PATCH and restart_all. 6. Still no 'Publication date text' column is visible. 7. Go to Administration > Table settings 8. Expose the column 9. Reload the OPAC page, you should see the new column. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 93e8f82c818e35403bc2d223805eea80e53be822 Author: David Cook Date: Mon Jan 6 23:39:25 2025 +0000 Bug 38832: (QA follow-up) Remove unused $page variables Signed-off-by: David Cook Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit 62c418b20ec99d6ccf89a609e8db31b610aba3f7 Author: Jonathan Druart Date: Mon Jan 6 16:04:55 2025 +0100 Bug 38832: Remove authority search from catalogue/search This one is less obvious, how is it possible to request an authority search using catalogue/search.pl? Is it dead code or is it actually used somewhere? Signed-off-by: David Cook Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit d5267ffa78fa4d331fb36ae5a78a2d4a1528337f Author: Jonathan Druart Date: Mon Jan 6 15:56:27 2025 +0100 Bug 38832: Remove code related to outer_servers_loop and outer_sup_servers_loop This is clearly dead code as it's never set in the controller file. Signed-off-by: David Cook Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit 143220d0c6d2d82bc007be029221ee3ede676f2f Author: Petro Vashchuk Date: Wed Sep 4 16:45:57 2024 +0300 Bug 37832: Fix Rental discount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Signed-off-by: Olivier V Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 96b86f9b27281f241df99b4f8f137f3ca2036872 Author: Lucas Gass Date: Thu Jan 2 18:43:30 2025 +0000 Bug 36585: (QA follow-up) Fix tab spaces Signed-off-by: Lucas Gass Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 212294b7f1654d9c4ef387803817e19f9bcf9da5 Author: Michael Hafen Date: Thu Apr 11 16:33:39 2024 -0600 Bug 36585: Improve 'Patrons with the most checkouts' report Update the 'Patrons with the most checkouts' report (bor_issues_top.pl) to: 1. Add the total to the CSV output. 2. Change the screen output to only show the patrons name once, instead of for each group by column. 3. Add total check out when output to screen. 4. Change item type group by from biblioitems.itemtype to items.itype. Note: This does not fix the SQL query so that it can run if the database is in strict mode. Test plan: 1. If using koha-testing-docker (KTD), set strict SQL mode for your database to 0 (that is, turn it off). (Edit 0 in /etc/koha/sites/kohadev/koha-conf.xml (and then flush_memcached and restart_all)) 2. Add some data so that a useful report can be generated: . Check out and return some items to different patrons in different libraries: ==> Minimum end result: . two items issued to a patron for one library, 1 item issued and returned for the same patron at another library . one item issued to another patron from another patron category for one of the libraries used previously 3. Generate the report with output to screen with a group by, for example: 'By' option set to Category code 4. Observe that the patron name is repeated for each column group. 5. Observe that there is no total column. 6. Generate the report with output to CSV. 7. Observe that the total checkouts is not in the CSV. 8. Apply the patch and restart Koha (restart_all). 9. Generate the CSV report again. 10. Observe that the total checkouts is in the CSV. 11. Generate the report to screen again. 12. Observe that there is a total column and the patron name is only shown in one column. Signed-off-by: David Nind Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit ada41ec13408ae654b10b4f400b0352a49de1cab Author: Baptiste Wojtkowski Date: Thu Jul 18 16:03:10 2024 +0200 Bug 18657: Add the possibility to add every items to the report Currently the tool reports: Incorrect not-for-loan values Wrong place Checked out We should have: Optional display of items w/o problems Display of missing/lost items now marked found TEST PLAN 1 - Mark an item as lost 2 - Go to tools->inventory 3 - Fill in the barcode list with the barcode of the item, notice there is one checkbox in "Additional options" 4 - Submit -> there should be no result 5 - Apply patches and redo 1,2&3 6 - Notice there are now 3 checkboxes in "Additional options" 7 - Click on "Add lost items to the report" 8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found" 9 - Go to tools->inventory 10 - Click on "Add lost items to the report" 11 - Submit -> there is no line in the report 12 - Go to tools->inventory 13 - Click on "Add items without problem to the report" 11 - Submit -> there is now line in the report with an empty problem Signed-off-by: Mathieu Saby Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 175a715078e572851c214ae14fa3eba1a6e7ef79 Author: Baptiste Wojtkowski Date: Thu Jul 18 15:05:58 2024 +0200 Bug 18657: Add the possibility to add lost items to the report Currently the tool reports: Incorrect not-for-loan values Wrong place Checked out We should have: Optional display of items w/o problems Display of missing/lost items now marked found TEST PLAN 1 - Mark an item as lost 2 - Go to tools->inventory 3 - Fill in the barcode list with the barcode of the item, notice there is one checkbox in "Additional options" 4 - Submit -> there should be no result 5 - Apply patches and redo 1,2&3 6 - Notice there are now 3 checkboxes in "Additional options" 7 - Click on "Add lost items to the report" 8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found" 9 - Go to tools->inventory 10 - Click on "Add lost items to the report" 11 - Submit -> there is no line in the report 12 - Go to tools->inventory 13 - Click on "Add items without problem to the report" 11 - Submit -> there is now line in the report with an empty problem Signed-off-by: Mathieu Saby Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 01071b2f1ac4fe6c51f8da59c6891b6c1088bd91 Author: Katrin Fischer Date: Thu Jan 16 15:55:05 2025 +0000 Bug 35154: DBRev 24.12.00.004 Signed-off-by: Katrin Fischer commit 30a2d78d538136f145a112adbc68c0fd91e5ffa4 Author: Owen Leonard Date: Fri Jan 10 20:13:48 2025 +0000 Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit d32a1b7063cbd380cd2e9935e4dc96dafcc557fa Author: Martin Renvoize Date: Mon Jan 13 07:50:00 2025 +0000 Bug 37546: Error message output improvements As suggested by David, I've re-arranged the message output so we pass 'message' first, followed by the error reference inside brackets, followed by "for SERVER" and finally "result No." This follows the Z39.50 suggestions more closely whilst still including our level of detail for Server + Result number. Signed-off-by: David Cook Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 03afbb442cbc1dffbb80d5f1812c2edb68e3b653 Author: Martin Renvoize Date: Thu Aug 1 16:37:45 2024 +0100 Bug 37546: Output error message from ZOOM in Z3950 errors Signed-off-by: David Cook Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit ea6a4db1b6ae85e03ec4fed1d898a1435ca2e040 Author: Matt Blenkinsop Date: Thu Nov 21 14:42:39 2024 +0000 Bug 36836: Amend translation fixes Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit beb8770bc967c25d89a4d148852b8c785fb006b8 Author: Katrin Fischer Date: Sun Jun 30 22:04:04 2024 +0000 Bug 36836: Fix translation issues in ERM module This tries to fix multiple translation issues in the ERM module. This includes: * Making strings translatable * Using double quotes instead of single around strings according to coding guidelines * Fixing some translations where the variable was marked for translation, but not the strings themselves: ...>{{ $__(item.tab_name) }} Amended-by: Jonathan Druart - {{ $__("Uploaded on:") }} + {{ $__("Uploaded on") }}: Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 020f709d64838a93de4f01e10c240c195734539b Author: Owen Leonard Date: Thu Nov 21 12:50:42 2024 +0000 Bug 38502: Use Bootstrap alert info class for messages on table settings page This patch updates the table settings template to add style to informational messages. To test, apply the patch and go to Administration -> Table settings. - Go to Catalog -> detail -> holdings_table. Above the table's settings you should see a message, "Please not that if a field..." It should have the standard Bootstrap "info" style. - Go to Cataloging -> additem. You should see a similarly styled message, "Changes made below..." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit ca181609e80070be761537f982b96c979ec28b15 Author: Katrin Fischer Date: Thu Jan 16 15:49:47 2025 +0100 Bug 38524: Update yarn.lock Signed-off-by: Katrin Fischer commit 66c244ebe40d30d5102cd51067614c51888523a6 Author: Victor Grousset Date: Sat Oct 19 15:13:58 2024 +0200 Bug 38524: Enable ESLint for .ts and .vue files Test plan: 1. Apply only bug 38167 and it's dependency (assuming they are not in main) 2. Restart KTD or run sudo yarn install --modules-folder /kohadevbox/node_modules 3. Run the following and see that it doesn't lint eslint t/cypress/integration/AdditionalFields_spec.ts eslint koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsReportBuilder.vue 4. Apply the patches of this ticket 5. restart KTD (it tests that the provisionning works well to get all the JS libs) 6. Run the following and see that it lints eslint t/cypress/integration/AdditionalFields_spec.ts eslint ./t/cypress/integration/ERM/DataProviders_spec.ts eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/modules/preservation.ts eslint koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsReportBuilder.vue eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue Various files tested here give an idea of the output, feel free to try others. And report stuff that should obviously be silenced due to making too much noise and having low value or being contrary to our current practices. Non obvious stuff to fix might be put in a follow-up ticket. --------- This was removed from config: indent: ["error", 4], Because this check was finding it redundant: npx eslint-config-prettier koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue check which is documented here: https://github.com/prettier/eslint-config-prettier?tab=readme-ov-file#cli-helper-tool To doubled check, I sabotaged some indentation in a .js/.ts section on these files koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue koha-tmpl/intranet-tmpl/prog/js/ajax.js And without `indent: ["error", 4]` the prettier rule was still reporting the issue. And with `indent: ["error", 4]` the issue was reported twice. This looks enough to confirm it's redundant to keep it. ---- For the same reason as above, the following was removed: semi: ["error", "always"], tested by removing a semicolon in koha-tmpl/intranet-tmpl/prog/js/ajax.js t/cypress/integration/Auth/csrf.ts ---- This was removed: "linebreak-style": ["error", "unix"], Because it's the default of prettier https://prettier.io/docs/en/options.html#end-of-line Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit e83a605f25ad9d3c48c01f7444e91efc3229b6bd Author: Victor Grousset Date: Mon Oct 14 19:17:04 2024 +0200 Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches BZ38700 will conflict with BZ38149 on yarn.lock solve conflict with sudo yarn install --modules-folder /kohadevbox/node_modules git bz apply --continue git will only continue for 38700 and don't actually apply this (38167) So retry git bz apply 38167 Don't apply the dependecies are they are already there. This time you're good :) (the conflict can't be durably solved because 38770 need to be applied independently or with BZ38149 depending on what other bug needs to be tested :/ ) 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7469403a014d7560c0c7a9ea245c4159e5e7a4b2 Author: Katrin Fischer Date: Thu Jan 16 15:44:15 2025 +0100 Bug 38770: Update yarn.lock Also includes changes from bug 38149. Signed-off-by: Katrin Fischer commit 4dbe67f6f263c81081cfe68320857153d5dd76b2 Author: Victor Grousset Date: Sun Dec 22 09:33:45 2024 +0100 Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 04aa82aa237d1b6768b8a6f25a74bea931d097d9 Author: Jonathan Druart Date: Thu Jan 16 09:37:19 2025 +0100 Bug 38149: Adjust tidy of some vue and js files after prettier upgrade Fix xt/js_tidy.t and xt/vue_tidy.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 3961a3fa559502df4ef522e5d968e8f1522e08c2 Author: Victor Grousset Date: Fri Oct 11 04:01:50 2024 +0200 Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 9a40d4418cfa113140667adafb9734f3b19c2897 Author: Victor Grousset Date: Fri Oct 11 04:01:04 2024 +0200 Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 1264622399485aeea07dce932097f1f4805f27e0 Author: Jonathan Druart Date: Mon Dec 9 12:21:34 2024 +0100 Bug 38632: Add tests You need bug 38461 to run successfully this test. Signed-off-by: Brendan Lawlor Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 0fefe2bed5192ef6f9fcf6864f8ffdb96d1a167a Author: Jonathan Druart Date: Mon Dec 9 12:19:45 2024 +0100 Bug 38632: Do not show all columns when displaying the filters Yet another visibility bug fix for this specific table. When the filters are displayed the table is destroyed and recreated. We should not save the visibility changes made by DT and consider them changes made by the user. A temporary variable is used to store the user settings duringt this action, then we restore them once it's done. Test plan: Go to the detail page of bibliographic record with items Click on "show filters" => Only columns displayed should still be displayed Retry but show/hide some columns before you display the filters => Only columns displayed should still be displayed Signed-off-by: Brendan Lawlor Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit bfd7d533f083336c6dcf8b31a8c054db18b0e7f7 Author: Victor Grousset Date: Wed Dec 4 22:25:54 2024 +0100 Bug 38461: Fix multiple case changes that broke variables Amended-by: Jonathan Druart - "x-base-total-count": baseTotalCount, - "x-total-count": baseTotalCount, + "X-Base-Total-Count": baseTotalCount, + "X-Total-Count": baseTotalCount, Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b2ec4e6dd4abbfef94765d31c89c512405d59c9e Author: Jonathan Druart Date: Wed Dec 4 14:30:06 2024 +0100 Bug 38461: Add tests for catalogue/detail/holdings_table Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 12e0d722c4676eb2c8d60f34014c198f6fc64d6b Author: Jonathan Druart Date: Thu Nov 28 12:23:36 2024 +0100 Bug 38461: Bypass the clipboard for tests There are known bugs with Cypress trying to play with the clipboard, and I don't manage to make the tests pass consistently (also tried realClick from cypress-real-events) Here I am suggesting to not click on the button, but simply retrieve the url (which needs a bit of work in the existing code). We don't test the "Copied!" tooltip and the behaviour of the button, but at least the tests pass! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit aab60455b50a708b247d8d1de68d049edf4ae087 Author: Jonathan Druart Date: Thu Nov 28 11:25:03 2024 +0100 Bug 38461: Fix random failures All this is weird. I found this and implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause-document-is-not-focused It was still not enough to reduce the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures... Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 79bc770baa7c774bd62184493df47905f267d71c Author: Jonathan Druart Date: Wed Nov 27 15:53:31 2024 +0100 Bug 38461: Jump to the configuration page Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7e9ce66bedfd304323be8f100b0a5d1a1b6019e0 Author: Jonathan Druart Date: Wed Nov 27 15:16:37 2024 +0100 Bug 38461: Shareable link Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3d6210552c1823f7d53ebde45db3418a8798ace8 Author: Jonathan Druart Date: Thu Nov 21 17:06:51 2024 +0100 Bug 38461: Refactoring - mock_table_settings Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f5a7c307da7b4fde9a8816cd83a79ecec8e5902a Author: Jonathan Druart Date: Thu Nov 21 16:42:34 2024 +0100 Bug 38461: Refactoring - build_libraries Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a55281fbca9bfcaa96e163df21c73a1734f9a4eb Author: Jonathan Druart Date: Thu Nov 21 16:40:08 2024 +0100 Bug 38461: Save state ON/OFF Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9544cbf977b2c6f6ad07347278683ce4aeeecdb2 Author: Jonathan Druart Date: Thu Nov 21 16:33:11 2024 +0100 Bug 38461: Columns - All, is_hidden by default, then shown by user Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6438b1e0e23eee93c5802dfc7b20f4d0e0a9d6c6 Author: Jonathan Druart Date: Thu Nov 21 14:00:18 2024 +0100 Bug 38461: Use buildSampleObjects Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b00b99f31de6d5a77626787bbaaa2cb123e7c5cb Author: Jonathan Druart Date: Wed Nov 20 16:07:39 2024 +0100 Bug 38461: Add tests for 'Clear filter' Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6a9870fd1c059f2c79025be4684c0a4bd2017c70 Author: Katrin Fischer Date: Thu Jan 16 13:08:52 2025 +0000 Bug 38503: Update yarn.lock Signed-off-by: Katrin Fischer