commit ca181609e80070be761537f982b96c979ec28b15 Author: Katrin Fischer Date: Thu Jan 16 15:49:47 2025 +0100 Bug 38524: Update yarn.lock Signed-off-by: Katrin Fischer commit 66c244ebe40d30d5102cd51067614c51888523a6 Author: Victor Grousset Date: Sat Oct 19 15:13:58 2024 +0200 Bug 38524: Enable ESLint for .ts and .vue files Test plan: 1. Apply only bug 38167 and it's dependency (assuming they are not in main) 2. Restart KTD or run sudo yarn install --modules-folder /kohadevbox/node_modules 3. Run the following and see that it doesn't lint eslint t/cypress/integration/AdditionalFields_spec.ts eslint koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsReportBuilder.vue 4. Apply the patches of this ticket 5. restart KTD (it tests that the provisionning works well to get all the JS libs) 6. Run the following and see that it lints eslint t/cypress/integration/AdditionalFields_spec.ts eslint ./t/cypress/integration/ERM/DataProviders_spec.ts eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/modules/preservation.ts eslint koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsReportBuilder.vue eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue Various files tested here give an idea of the output, feel free to try others. And report stuff that should obviously be silenced due to making too much noise and having low value or being contrary to our current practices. Non obvious stuff to fix might be put in a follow-up ticket. --------- This was removed from config: indent: ["error", 4], Because this check was finding it redundant: npx eslint-config-prettier koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue check which is documented here: https://github.com/prettier/eslint-config-prettier?tab=readme-ov-file#cli-helper-tool To doubled check, I sabotaged some indentation in a .js/.ts section on these files koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue koha-tmpl/intranet-tmpl/prog/js/ajax.js And without `indent: ["error", 4]` the prettier rule was still reporting the issue. And with `indent: ["error", 4]` the issue was reported twice. This looks enough to confirm it's redundant to keep it. ---- For the same reason as above, the following was removed: semi: ["error", "always"], tested by removing a semicolon in koha-tmpl/intranet-tmpl/prog/js/ajax.js t/cypress/integration/Auth/csrf.ts ---- This was removed: "linebreak-style": ["error", "unix"], Because it's the default of prettier https://prettier.io/docs/en/options.html#end-of-line Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit e83a605f25ad9d3c48c01f7444e91efc3229b6bd Author: Victor Grousset Date: Mon Oct 14 19:17:04 2024 +0200 Bug 38167: Migrate ESLint config to new flat format Test: 1. Do not apply 2. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 3. It should fail 4. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 5. It should work 6. Apply patches BZ38700 will conflict with BZ38149 on yarn.lock solve conflict with sudo yarn install --modules-folder /kohadevbox/node_modules git bz apply --continue git will only continue for 38700 and don't actually apply this (38167) So retry git bz apply 38167 Don't apply the dependecies are they are already there. This time you're good :) (the conflict can't be durably solved because 38770 need to be applied independently or with BZ38149 depending on what other bug needs to be tested :/ ) 7. Restart KTD to have a clean state of dependencies and check that provisionning still works. 8. ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 9. It should fail 10. eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 11. It should work Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7469403a014d7560c0c7a9ea245c4159e5e7a4b2 Author: Katrin Fischer Date: Thu Jan 16 15:44:15 2025 +0100 Bug 38770: Update yarn.lock Also includes changes from bug 38149. Signed-off-by: Katrin Fischer commit 4dbe67f6f263c81081cfe68320857153d5dd76b2 Author: Victor Grousset Date: Sun Dec 22 09:33:45 2024 +0100 Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 04aa82aa237d1b6768b8a6f25a74bea931d097d9 Author: Jonathan Druart Date: Thu Jan 16 09:37:19 2025 +0100 Bug 38149: Adjust tidy of some vue and js files after prettier upgrade Fix xt/js_tidy.t and xt/vue_tidy.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 3961a3fa559502df4ef522e5d968e8f1522e08c2 Author: Victor Grousset Date: Fri Oct 11 04:01:50 2024 +0200 Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 9a40d4418cfa113140667adafb9734f3b19c2897 Author: Victor Grousset Date: Fri Oct 11 04:01:04 2024 +0200 Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 1264622399485aeea07dce932097f1f4805f27e0 Author: Jonathan Druart Date: Mon Dec 9 12:21:34 2024 +0100 Bug 38632: Add tests You need bug 38461 to run successfully this test. Signed-off-by: Brendan Lawlor Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 0fefe2bed5192ef6f9fcf6864f8ffdb96d1a167a Author: Jonathan Druart Date: Mon Dec 9 12:19:45 2024 +0100 Bug 38632: Do not show all columns when displaying the filters Yet another visibility bug fix for this specific table. When the filters are displayed the table is destroyed and recreated. We should not save the visibility changes made by DT and consider them changes made by the user. A temporary variable is used to store the user settings duringt this action, then we restore them once it's done. Test plan: Go to the detail page of bibliographic record with items Click on "show filters" => Only columns displayed should still be displayed Retry but show/hide some columns before you display the filters => Only columns displayed should still be displayed Signed-off-by: Brendan Lawlor Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit bfd7d533f083336c6dcf8b31a8c054db18b0e7f7 Author: Victor Grousset Date: Wed Dec 4 22:25:54 2024 +0100 Bug 38461: Fix multiple case changes that broke variables Amended-by: Jonathan Druart - "x-base-total-count": baseTotalCount, - "x-total-count": baseTotalCount, + "X-Base-Total-Count": baseTotalCount, + "X-Total-Count": baseTotalCount, Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b2ec4e6dd4abbfef94765d31c89c512405d59c9e Author: Jonathan Druart Date: Wed Dec 4 14:30:06 2024 +0100 Bug 38461: Add tests for catalogue/detail/holdings_table Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 12e0d722c4676eb2c8d60f34014c198f6fc64d6b Author: Jonathan Druart Date: Thu Nov 28 12:23:36 2024 +0100 Bug 38461: Bypass the clipboard for tests There are known bugs with Cypress trying to play with the clipboard, and I don't manage to make the tests pass consistently (also tried realClick from cypress-real-events) Here I am suggesting to not click on the button, but simply retrieve the url (which needs a bit of work in the existing code). We don't test the "Copied!" tooltip and the behaviour of the button, but at least the tests pass! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit aab60455b50a708b247d8d1de68d049edf4ae087 Author: Jonathan Druart Date: Thu Nov 28 11:25:03 2024 +0100 Bug 38461: Fix random failures All this is weird. I found this and implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause-document-is-not-focused It was still not enough to reduce the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures... Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 79bc770baa7c774bd62184493df47905f267d71c Author: Jonathan Druart Date: Wed Nov 27 15:53:31 2024 +0100 Bug 38461: Jump to the configuration page Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7e9ce66bedfd304323be8f100b0a5d1a1b6019e0 Author: Jonathan Druart Date: Wed Nov 27 15:16:37 2024 +0100 Bug 38461: Shareable link Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3d6210552c1823f7d53ebde45db3418a8798ace8 Author: Jonathan Druart Date: Thu Nov 21 17:06:51 2024 +0100 Bug 38461: Refactoring - mock_table_settings Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f5a7c307da7b4fde9a8816cd83a79ecec8e5902a Author: Jonathan Druart Date: Thu Nov 21 16:42:34 2024 +0100 Bug 38461: Refactoring - build_libraries Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a55281fbca9bfcaa96e163df21c73a1734f9a4eb Author: Jonathan Druart Date: Thu Nov 21 16:40:08 2024 +0100 Bug 38461: Save state ON/OFF Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9544cbf977b2c6f6ad07347278683ce4aeeecdb2 Author: Jonathan Druart Date: Thu Nov 21 16:33:11 2024 +0100 Bug 38461: Columns - All, is_hidden by default, then shown by user Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6438b1e0e23eee93c5802dfc7b20f4d0e0a9d6c6 Author: Jonathan Druart Date: Thu Nov 21 14:00:18 2024 +0100 Bug 38461: Use buildSampleObjects Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b00b99f31de6d5a77626787bbaaa2cb123e7c5cb Author: Jonathan Druart Date: Wed Nov 20 16:07:39 2024 +0100 Bug 38461: Add tests for 'Clear filter' Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6a9870fd1c059f2c79025be4684c0a4bd2017c70 Author: Katrin Fischer Date: Thu Jan 16 13:08:52 2025 +0000 Bug 38503: Update yarn.lock Signed-off-by: Katrin Fischer commit 9f5f4aa1d63f24c7aa84e2428f67825e6feba0b3 Author: Jonathan Druart Date: Wed Dec 4 14:05:51 2024 +0100 Bug 38503: Do not list the objects No need to list all the objects, just retrieve the spec depending on the "object" var we pass. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit ddd22c788710b97a43b84cc81fd8b66fe10dd153 Author: Jonathan Druart Date: Thu Nov 21 15:13:10 2024 +0100 Bug 38503: Generate correct values for date and date-time Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3bc9bd8b6292394889ef5ad3e18ae13a2b0d48eb Author: Jonathan Druart Date: Thu Nov 21 15:00:26 2024 +0100 Bug 38503: Deal with types that can be "null" Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 34f666337458cda9c3b922dfa96dff373d8350cb Author: Jonathan Druart Date: Thu Nov 21 14:08:19 2024 +0100 Bug 38503: Allow to pass values Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3f880c5978bff78965f4bb2cb907c73347ca32f8 Author: Jonathan Druart Date: Thu Nov 21 14:07:31 2024 +0100 Bug 38503: Have a generic buildSampleObject[s] Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7b3426928f894fc5007e4c4dca5954576ecd3540 Author: Jonathan Druart Date: Thu Nov 21 14:06:41 2024 +0100 Bug 38503: Same for libraries Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit bad59ca734db978e8de069e62c9e2cae1827ae7d Author: Jonathan Druart Date: Thu Nov 21 14:05:33 2024 +0100 Bug 38503: Implement a plural form - buildSamplePatrons Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3a3294966a6da7f172c86ddac0d4a3c1448453d4 Author: Jonathan Druart Date: Thu Nov 21 14:00:05 2024 +0100 Bug 38503: Read patron swagger spec file and implement buildSamplePatron Test plan: 1. Install deps sudo yarn install --modules-folder /kohadevbox/node_modules 2. Run tests cypress run --config video=false --spec t/cypress/integration/t/mockData.ts Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 91fd218fc6dbf381a951724f64b288f6410e031d Author: David Cook Date: Mon Nov 18 05:15:26 2024 +0000 Bug 38470: Add missing double quotes to some Javascript This change adds some double quotes where quotes were missing, and replaces single quotes with double quotes, which prevents XSS. Test plan: 0. Apply the patch 1. Create a subscription 2. Using the ID from the subscription, go to this page: http://localhost:8081/cgi-bin/koha/serials/subscription-detail.pl? print_routing_list_issue=1&subscriptionid= 3. Note that you're able to generate a print slip (You may need to allow popups) 4. To check the security vulnerability is fixed, try the proof-of-concepts attached to the bug report Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer commit b898d117b75248cc24ce4cd3f6162d976f65d094 Author: David Cook Date: Mon Nov 18 04:14:37 2024 +0000 Bug 38468: Add double quotes to some template strings This change adds double quotes to some template strings where quotes are missing all together or single quotes are used incorrectly. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Click on "Gairm" 3. Use the search result navigation box to go to the next result On the left of the page. Just bellow the breadcrumb and left of the record title. 4. Note that everything loads correctly 5. To test that the security hole has been fixed, try some of the proof-of-concept attacks provided for biblionumber and searchid Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit cc6fbe05004d344ad359746ae30e72a86963cf0f Author: David Cook Date: Thu Oct 17 05:35:56 2024 +0000 Bug 37727: Prevent CSV Formula injection via DataTables This change prevents CSV Formula injection on DataTables exports by escaping formula with a single quote prefix as per OWASP recommendations. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl ?op=edit_form&destination=circ&borrowernumber=51 2. Add the following in a "Circulation note" =SUM(1+1) 3. Go to http://localhost:8081/cgi-bin/koha/members/member.pl ?quicksearch=1&circsearch=1&searchmember=koha 4. Click "Export" and choose "Excel" and "CSV" 5. Open those downloaded files in Excel 6. Note that the =SUM(1+1) function is prefixed with a single quote, and is not automatically executed Signed-off-by: Magnus Enger Works as advertised. The problematic "cell" is exported as "'=SUM(1+1)". Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer commit 3fc855f568c2c874eaadd5cc572f9a9a9746ff48 Author: Caroline Cyr La Rose Date: Thu Jan 9 12:49:37 2025 -0500 Bug 38856: Typo: EmailAddressForPatronRegistrations - "chooose" This patch fixes a typo in the description of the EmailAddressForPatronRegistrations system preference. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for EmailAddressForPatronRegistrations 4. Read the description (2nd line) and make sure the spelling is correct Signed-off-by: Magnus Enger Works as advertised. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit ede69d5c5fe01590540313b637ac756f7cc7dd12 Author: Nicolas Hunstein Date: Fri Jan 10 13:48:25 2025 +0000 Bug 38471: update "Field suppresion" to "Field suppression" updates "Field suppresion" to "Field suppression" to test: - go to Administration/Authority types/Default framework/Tag 090 - verify description for subfield t is Field suppresion, FSP (RLIN) - apply patch - reset database or reset_all - verify description has changed to Field suppression,FSP (RLIN) Signed-off-by: William Lavoie Signed-off-by: Brendan Lawlor Signed-off-by: Katrin Fischer commit bdcbcc0a33bbe944280b47307b84e8ef2499e838 Author: David Nind Date: Mon Dec 16 19:34:10 2024 +0000 Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind Signed-off-by: Leo Stoyanov Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 55632527fc3ec79ec5c92a0772fe739490a6afe0 Author: Caroline Cyr La Rose Date: Tue Jan 7 16:50:05 2025 -0500 Bug 38845: OpacNoItemTypeImages required to show item type images in staff interface advanced search This patch makes it so that the noItemTypeImages system preference is the one that controls the display of item type images in the staff interface advanced search page. It was previously erroneously managed by the OpacNoItemTypeImages system preference. To test: 1. Add images to item types, if there aren't any already (KTD has them by default) 1.1. Go to Administration > Item types 1.2. Click 'Edit' next to one of the item types 1.3. Choose an icon 1.4. Click 'Save changes' 2. Disable OpacNoItemTypeImages 3. Enable noItemTypeImages (already enabled in KTD) 4. Go to the advanced search page --> The item types don't have any images next to them 5. Apply patch and refresh the page --> The item type images should be displayed Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 814e1326b7b1fafed3c0164c1f6616a06923d879 Author: Imani Thomas Date: Wed Jan 8 13:28:13 2025 +0000 Bug 36229: Move koha-run-backups to the top of the cron test plan: 1. check run order of scripts in the cron 2. apply patch 3. koha-run-backups is now at the beginning of the cron Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 90774b33a7f77643fb8881271d10521a35a8982a Author: Jonathan Druart Date: Thu Jan 9 15:04:09 2025 +0100 Bug 38855: (bug 22056 follow-up) Remove 'test' directory template-side This should have been removed by bug 22056 Signed-off-by: William Lavoie Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 642f21a6f2ccaa9cdd15e047be328809adcfd512 Author: Pedro Amorim Date: Thu Nov 21 14:23:55 2024 -0100 Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: Ray Delahunty Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit ecd0604a8ded12803846de6d3e7dac5e9eed2765 Author: Pedro Amorim Date: Thu Nov 21 13:32:02 2024 +0000 Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message Test plan, before applying patches: 1) Enable ILLModule system preferece. 2) Create a book ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio 4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode) 5) Repeat 2) -> Click confirm request and continue. 6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again. 7) Notice the message "An unknown error occurred while trying to checkout the item" 8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'. This patch also adds a link to the respective biblio for Staff members' convenience. Signed-off-by: Ray Delahunty Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 90304e7632547fcb275d93a88afc88e4a52dd1ed Author: Pedro Amorim Date: Thu Nov 21 13:31:37 2024 +0000 Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists Cosmetic changes only. Signed-off-by: Ray Delahunty Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 89b7f160a75e063582793a30636c137ddacdc96d Author: Pedro Amorim Date: Thu Nov 21 14:23:19 2024 -0100 Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Ray Delahunty Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 45626c75c4d83075892015233634106814f26942 Author: Pedro Amorim Date: Thu Nov 21 15:37:09 2024 +0000 Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode prove t/db_dependent/Circulation.t Signed-off-by: Ray Delahunty Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 25fd2621927a8326a18521e3dcc87a9d504c7140 Author: Martin Renvoize Date: Wed Jan 8 16:31:28 2025 +0000 Bug 37448: (QA follow-up) Move POD to make QA Script happy This particular script has POD at the end rather than inline POD. This patch simply moves the POD addition for this patchset into the bottom section. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c42cfecd43b36048414615622f7121c7de31e657 Author: Pedro Amorim Date: Wed Jul 24 13:45:05 2024 +0000 Bug 37448: Add build_sample_ill_request The linked biblio_id of a generated test ILL request needs to be created by build_sample_biblio->AddBiblio. Or else the related biblio is created by just 'build' and is not indexed + its related metadata is missing. To test: 1) Apply the [DONT PUSH] patch and enable ILLModule 2) Run the script for ILL requests: misc/devel/create_test_data.pl -n 5 -s Illrequest -d backend=Standard 3) Visit the ILLModule: http:///cgi-bin/koha/ill/ill-requests.pl 4) Notice it loads 5 test ILL requests correctly Signed-off-by: Pedro Amorim Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 576621a6dfe447ae190ce6be3c8a5bcefd3d11fc Author: Kyle M Hall Date: Wed Jul 24 08:16:19 2024 -0400 Bug 37448: Add script to allow developers to quickly generate large amounts of data for development and testing Test Plan: 1) Apply this patch 2) Run: misc/devel/create_test_data.pl -n 99 -s Borrower -d surname=Hall -d zipcode=111111 3) Search patrons' for the name "Hall" 4) Note there are 99 Hall's in your results! Signed-off-by: Kyle M Hall Signed-off-by: Pedro Amorim Bug 37448: Make use of build_sample_biblio and build_sample_item The script is brilliant, but for biblios and items we should make use of build_sample_biblio and build_sample_item or this data does not get indexed + linked tables rows get missed To test, before this patch, run: 1) misc/devel/create_test_data.pl -n 5 -s Biblio -d title=Test Notice the 'Test' biblio is created on the database, but doesnt show on searches, and accessing it directly through URL throws a 500 error (because metadata does not exist for the biblio) 2) Apply this patch. Repeat the step above. Notice it now shows on searches and visiting the biblio directly shows no errors Signed-off-by: Pedro Amorim Signed-off-by: Kyle M Hall Bug 37448: (QA follow-up) Tidy script Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 92fd65840a8d8c3f915d4ecf545fd5b3eaaebe18 Author: Pedro Amorim Date: Fri Jan 3 12:15:47 2025 -0100 Bug 38751: Update Standard ILL backend migrate Make use of newly updated ILL::Request->extended_attributes method instead of creating the query manually The test plan in bug 38819 fails without this patch (page explodes with duplicate ID error). It's the same cause as the one being fixed here in bug 38751 so I'm submitting this here. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6526e003747df203e48eb134ec964dec652ba4bb Author: Pedro Amorim Date: Thu Dec 19 11:57:07 2024 +0000 Bug 38751: Update Standard ILL backend add_request Make use of newly updated ILL::Request->extended_attributes method instead of creating the query manually Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer